-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maint-3.10 branch doesn't actually appear to be GR3.10 compatible? #49
Labels
Comments
ion-concepts
changed the title
main-3.10 branch doesn't actually appear to be GR3.10 compatible?
maint-3.10 branch doesn't actually appear to be GR3.10 compatible?
Nov 13, 2023
yep, stumbled across the same yesterday on stage. oops. Fixed that in a PR. Sorry, @ion-concepts ! |
can you try #52 , @ion-concepts ? Note that I tried nothing but running the unit tests after these fixes. |
Confirm I can now build this against current GR maint-3.10. index e299956..5384a7d 100644
--- a/lib/ofdm_bouzegzi_c_impl.cc
+++ b/lib/ofdm_bouzegzi_c_impl.cc
@@ -26,7 +26,7 @@
#include <gnuradio/gr_complex.h>
#include <gnuradio/io_signature.h>
#include <gnuradio/logger.h>
-#include <spdlog/fmt/ranges.h>
+#include <spdlog/fmt/bundled/ranges.h>
#include <volk/volk.h>
#include <volk/volk_alloc.hh>
#include <complex> |
Oh nice! Thanks!
Thankfully, under C++17, the preprocessors can check for existence if headers, so I think I can make that portable! Awesome!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
maint-3.10
andmain
fail to build against GR 3.10.8 because of use of the __GR_VLA macro which was removed from GR3.10 @a2f39b26239784bf6b01e3c289fb0f90041167ceThe text was updated successfully, but these errors were encountered: