Restore Buildability on main, warn about broken block #52
+219
−264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 30, 2024 15:15
Required a bunch of mallocs/volk_allocs with volk::vectors. Also, bouzegzi seems algorithmically broken, so add a clear compile warning. Fly-by fixes on comparing signed integers to unsigned vector lengths, hard to detangle from fixing the VLA usage. Signed-off-by: Marcus Müller <[email protected]>
Signed-off-by: Marcus Müller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49
__GR_VLA was removed, and should have been volk/std::vector usage to begin with. So, we fix that.
Since we're now handling former VLAs as vectors, we mix destructors, volk_free and free. That is annoying, and rich in, partially very correct, warnings.
So, convert most malloc'ed things to vectors, manually managed ffts to unique_ptr.
Also, there was API misuse in fft_complex_fwd; it's fft_complex_fwd(length, threads), not fft_complex_fwd(length, direction). Luckily, nothing used any direction but forward.