Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial test for NSStackView, also adding tests for other new classes... #213

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gcasa
Copy link
Member

@gcasa gcasa commented Nov 27, 2023

I am going to incorporate many of the independent tests into GUI's test suite as well as add some additional logic to check that things are being positioned / computed correctly.

@gcasa
Copy link
Member Author

gcasa commented Apr 21, 2024

These are simple tests that only test the loading of these new classes. They are a start for more in depth tests.

@gcasa gcasa marked this pull request as ready for review April 21, 2024 10:31
@gcasa gcasa requested a review from fredkiefer as a code owner April 21, 2024 10:31
@fredkiefer
Copy link
Member

With this sort of tests I am a bit unsure where we should put them. The tests in the libs-gui/Test directory are intended to be run from the CI pipeline. And these new tests don't make much sense in this respect. Maybe we could put them into the examples project? On the other hand nobody ever executes the tests there. Maybe a new directory in the libs-gui project would do? As I said, I am unsure here and maybe we should start a discussion on the mailing list?

@gcasa
Copy link
Member Author

gcasa commented Apr 22, 2024

With this sort of tests I am a bit unsure where we should put them. The tests in the libs-gui/Test directory are intended to be run from the CI pipeline. And these new tests don't make much sense in this respect. Maybe we could put them into the examples project? On the other hand nobody ever executes the tests there. Maybe a new directory in the libs-gui project would do? As I said, I am unsure here and maybe we should start a discussion on the mailing list?

I think that moving them to examples would be sufficient. I really would like more tests in gui but I am not entirely sure what kind of tests we can add as gui is harder to test.

@gcasa
Copy link
Member Author

gcasa commented Apr 25, 2024

Per discussion i am going to move these to the examples directory.

@gcasa gcasa marked this pull request as draft May 8, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants