-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated PR for NSOutlineView/NSTreeController due to refactor #277
base: master
Are you sure you want to change the base?
Conversation
…ew was refactored
@fredkiefer This is not yet ready for review. I will convert it when it is. Thanks. |
Interesting indeed...
I am introducing an equivalent class GSControllerTreeProxy to fill this role, it will be a subclass of NSTreeNode, just as _NSTreeControllerProxy is. Apparently, NSTreeController is not meant to handle an NSArray of objects. This is apparent from the documentation as I will need to work out the nuances of how this handles various bindings. |
The test for this is here... https://github.com/gcasa/NSTreeController_test |
… helpers, remove debugging code from binding connector and outline
…taSource or if we have a binding, also use it in the loadItem... method so the logic for this is in ONE place
I am marking this as ready for review and proceeding to optimize and clean up the code in preparation for merge. |
@fredkiefer These changes are mainly about the binding between NSTreeController and NSOutlineView. More changes might be forthcoming, but I will do some of the other methods as separate PR. Please take a moment to review. |
Subject summarizes. This PR is meant to implement NSTreeController and NSOutlineView integration. I made a new branch since NSOutlineView was heavily modified in the PR addressing NSTableRowView here.