Migrate from ioutil to io
#976
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi, thanks for your contribution.
However, I just merged a similar PR #962, which came first.
Feel free to rebase and submit the other contributions separately. Thanks!
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
|
@VojtechVitek I have rebased |
pkieltyka
reviewed
Feb 12, 2025
| @@ -444,34 +443,6 @@ func TestTreeFindPattern(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func debugPrintTree(parent int, i int, n *node, label byte) bool { | |||
There was a problem hiding this comment.
keep this code, its handy if we ever need it again
pkieltyka
requested changes
Feb 12, 2025
| @@ -148,7 +148,7 @@ func (n *node) InsertRoute(method methodTyp, pattern string, handler http.Handle | |||
|
|
|||
| // We're going to be searching for a wild node next, | |||
| // in this case, we need to get the tail | |||
| var label = search[0] | |||
There was a problem hiding this comment.
change style back as how it was please
| @@ -242,7 +242,6 @@ func (n *node) addChild(child *node, prefix string) *node { | |||
|
|
|||
| // Add child depending on next up segment | |||
| switch segTyp { | |||
|
|
|||
There was a problem hiding this comment.
keep the spacing between lines as it is.. I prefer it.. more readable
| nMagenta = []byte{'\033', '[', '3', '5', 'm'} | ||
| nCyan = []byte{'\033', '[', '3', '6', 'm'} | ||
| nWhite = []byte{'\033', '[', '3', '7', 'm'} | ||
| nRed = []byte{'\033', '[', '3', '1', 'm'} |
|
Given we merged the "io" changes in #962, I'll close this one. Let's keep the code style and debugging code intact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the codebase to replace the deprecated ioutil package with the modern io package functions, while also applying additional code style and formatting improvements. The implementation updates function calls, simplifies goroutine closures, removes obsolete debugging code, and standardizes variable declarations to improve clarity and maintainability.
Related to #962