Skip to content

Retry: replace log with log/slog #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Retry: replace log with log/slog #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9e3161
retry: replace log with log/slog
CondensedTea Apr 20, 2025
ac0c65e
bump minimal Go version in `go.mod`
CondensedTea Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module github.com/go-chi/transport

go 1.14
go 1.21

require golang.org/x/sync v0.4.0
26 changes: 18 additions & 8 deletions retry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,33 @@
package transport

import (
"log/slog"
"math"
"net/http"
"log"
"time"
"strconv"
"math"
"time"
)

func Retry(baseTransport http.RoundTripper, maxRetries int) func(http.RoundTripper) http.RoundTripper {
return func(next http.RoundTripper) http.RoundTripper {
return RoundTripFunc(func(req *http.Request) (resp *http.Response, err error) {
defer func() {
if isRetryable(resp) {
ctx := req.Context()

for i := 1; i <= maxRetries; i++ {
wait := backOff(resp, i)

timer := time.NewTimer(wait)

log.Printf("waiting %s", wait.String())
slog.LogAttrs(ctx, slog.LevelDebug, "waiting for backoff",
slog.String("wait", wait.String()),
slog.Int("attempt", i),
)

select {
case <-req.Context().Done():
log.Printf("request was cancelled")
case <-ctx.Done():
slog.Log(ctx, slog.LevelDebug, "request was cancelled")
timer.Stop()
break
case <-timer.C:
Expand All @@ -34,8 +39,13 @@ func Retry(baseTransport http.RoundTripper, maxRetries int) func(http.RoundTripp
break
}

log.Printf("retrying %d request: %s %s", i, req.Method, req.URL)
log.Printf("response (%v): %v %s", time.Since(startTime), resp.Status, resp.Request.URL)
slog.LogAttrs(ctx, slog.LevelWarn, "retrying request",
slog.Int("attempt", i),
slog.String("method", req.Method),
slog.String("url", req.URL.String()),
slog.String("response.status", resp.Status),
slog.Duration("response.duration", time.Since(startTime)),
)
}
}
}()
Expand Down