Add utc_timestamp tag for time.Time in UTC, fixes #60 #73
+115
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ThanhPham1003 try update your branch, our pipeline was having some issues that were provoking failures for the testing steps. |
geshtng
reviewed
May 28, 2025
| } | ||
| val, err := d.UTCTimestampValue(reflect.ValueOf(&ref.some).Elem()) | ||
| if err != nil { | ||
| t.Error("function UTCTimestampValue need return valid value") |
There was a problem hiding this comment.
Suggested change
| t.Error("function UTCTimestampValue need return valid value") | |
| t.Error("function UTCTimestampValue needs to return a valid value") |
Comment on lines
+277
to
+278
| if time.Now().Unix() <= result.Unix() { | ||
| t.Error("UTCTimestamp should return time <= now") |
There was a problem hiding this comment.
Let's make this condition easier to understand and consistent with the error message.
Suggested change
| if time.Now().Unix() <= result.Unix() { | |
| t.Error("UTCTimestamp should return time <= now") | |
| if result.Unix() > time.Now().Unix() { | |
| t.Error("UTCTimestamp should return time <= now") |
We should use > instead of >= because if result == now, the current logic would still trigger an error, even though it satisfies the expectation (result <= now).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #60
utc_timestamptag to generatetime.Timevalues in UTC.UTCTimestampandUTCTimestampValueindatetime.go.datetime_test.gofollowingTestUnixTimeValueValidstyle.