proposal: split org Propfile README to a new tab overview
#31373
+67
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
like user profile, add a new overviw tab to show profile READEME when it is exist. Signed-off-by: a1012112796 <[email protected]>
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
github-actions
bot
added
modifies/go
a1012112796
added
the
type/proposal
a1012112796
changed the title
overviewoverview
|
Looks like Github's default page is repositories list. |
|
Github renders:
I suggest we do the same, which should make everyone happy. |
No, if I open https://github.com/go-gitea, it goes to the the overview tab. |
Signed-off-by: a1012112796 <[email protected]>
has add it 990584f |
silverwind
reviewed
Jun 17, 2024
templates/org/menu.tmpl
Outdated
| {{svg "octicon-info"}} {{ctx.Locale.Tr "user.overview"}} | ||
| </a> | ||
| {{end}} | ||
| <a class="{{if .PageIsViewRepositories}}active {{end}}item" href="{{$.Org.HomeLink}}{{if .HasProfileReadme}}?view_repositorys=true{{end}}"> |
There was a problem hiding this comment.
Can you make this route /<orgname>/repositories please? Query string is ugly and your view_repositorys is actually a typo.
Signed-off-by: a1012112796 <[email protected]>
pull-request-size
bot
added
size/L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
like user profile, add a new overviw tab to show profile READEME when it is exist.
replace #31349 (another solution option)
example view:
