Improve flex-item overflow
#31404
Draft
Improve flex-item overflow
#31404
+35
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
the
modifies/templates
wxiaoguang
reviewed
Jun 17, 2024
| display: inline; | ||
| } | ||
| .flex-item-title-inline > * { | ||
| display: inline !important; |
There was a problem hiding this comment.
It doesn't look good to me.
- It introduces unclear style overriding game again.
- There could be "SVG/emoji" in the labels, so the "flex align item center" was done intentionally, but now I do not know whether "inline+vertical-align" works.
There was a problem hiding this comment.
At minimum the children must be display: inline. Parent actually does not need it. Could maybe check if we can get both elements to naturally display: inline, e.g. span/a without any CSS that alters display.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, labels could not break onto multiple lines when overflowing. Fix this by adding a wrapper element that sets
display: inlinewhich as far as I'm aware is the onlydisplaymode that achieves such overflow. Also introduced a breakpoint at 600px where the item goes into column layout.Diff: https://github.com/go-gitea/gitea/pull/31404/files?diff=unified&w=1
Desktop before/after:
Mobile before/after: