Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

actions view: move loading of task attributes etc... into own func #31494

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

actions view: move loading of task attributes etc... into own func #31494

wants to merge 5 commits into from

Conversation

6543
Copy link
Member

@6543 6543 commented Jun 25, 2024

just a smal refactor to make the function length smaler ... and code more reusable in the future

@6543 6543 added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jun 25, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 25, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 25, 2024
@6543 6543 requested a review from techknowlogick June 25, 2024 22:30
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jun 25, 2024
@6543
Copy link
Member Author

6543 commented Jun 25, 2024

review it via: https://github.com/go-gitea/gitea/pull/31494/files?diff=unified&w=1 make it simple :D

@6543 6543 requested a review from KN4CK3R June 30, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techknowlogick techknowlogick Awaiting requested review from techknowlogick

@KN4CK3R KN4CK3R Awaiting requested review from KN4CK3R

Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@6543 @KN4CK3R @GiteaBot