Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization of labels handling in issue_search (#26460) #31495

Open
wants to merge 1 commit into
base: release/v1.22
Choose a base branch
from
Open

Optimization of labels handling in issue_search (#26460) #31495

wants to merge 1 commit into from

Conversation

GiteaBot
Copy link
Contributor

@GiteaBot GiteaBot commented Jun 26, 2024 •
edited by wxiaoguang
Loading

Backport #26460 by xlii-chl

@xlii-chl @techknowlogick @GiteaBot
Optimization of labels handling in issue_search (go-gitea#26460)
944f6f2 
This PR enhances the labels handling in issue_search by optimizing the
SQL query and de-duplicate the IDs when generating the query string.

---------

Co-authored-by: techknowlogick <[email protected]>
@GiteaBot GiteaBot added modifies/go Pull requests that update Go code performance/speed performance issues with slow downs type/enhancement An improvement of existing functionality labels Jun 26, 2024
@GiteaBot GiteaBot added this to the 1.22.1 milestone Jun 26, 2024
@GiteaBot GiteaBot requested a review from lunny June 26, 2024 00:26
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 26, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 26, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 26, 2024
techknowlogick
techknowlogick requested changes Jun 26, 2024
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"requesting changes" on this PR as a way to hold it until the other PR attached to main is reviewed.

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techknowlogick techknowlogick techknowlogick requested changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged modifies/go Pull requests that update Go code performance/speed performance issues with slow downs size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.22.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GiteaBot @lunny @techknowlogick @xlii-chl