-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Passkey login support #31504
Add Passkey login support #31504
Conversation
Unrelated, but I see we need to increase contrast on these error message headers :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks alright, but I have not tested it.
Co-authored-by: silverwind <[email protected]>
Thank you for your contributions. But I don't think the login UI is ideal. Maybe we can have a redesign because of Passkey login supported? |
Sure, I am open for suggestions. Using a link seemedd nice as it isn't to dominated compared to another button as not every system is supporting passkeys yet. Mainly orientated on Githubs approach (which seems pretty clean): |
I think we could do the same and separate the links into a separate box. Moving the "Forget Password" besides the password label is also a good idea to make it look less crammed. I can help on these parts if you like. |
That sounds great. Feel free to push to this PR. |
I will. Another change I plan is to make the "Sign In" button full width. It'll look better, be easier to click and match the OAuth buttons as well. |
@silverwind Did some testing: |
closes #22015
After adding a passkey, you can now simply login with it directly by clicking
Sign in with a passkey
.Note for testing. You need to run gitea using
https
to get the full passkeys experience.