Fix trimming of leading and trailing spaces when adding a new file #31507
Conversation
pull-request-size
bot
added
the
size/XS
GiteaBot
added
the
lgtm/need 2
GiteaBot
added
lgtm/need 1
| for i, v := range treePath { | ||
| treePath[i] = strings.TrimSpace(v) | ||
| } | ||
| form.TreePath = strings.Join(treePath, "/") |
There was a problem hiding this comment.
Hmm, the path could be something like / / / /, just press Space Slash Space Slash on the editor page 🤣
Then the tree path becomes "////", which doesn't seem good.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Then the tree path becomes "////", which doesn't seem good.
I assume the backend would reject that? Seems like right behaviour to me.
There was a problem hiding this comment.
There are more edge cases: for example, what happens to foo/ .. /bar? Will it be rejected or become foo/../bar then become bar?
There was a problem hiding this comment.
GitHub has another good behavior: if ../ is inputted, then it changes the path to parent, not sure whether it is implemented in Gitea's UI.
There was a problem hiding this comment.
Tested with GitHub, I think GitHub also uses my suggestion: do not do too much for end users, only warn them.
On GitHub, it shows a warning but does not take any action for users. This is my test: 't2 / t3 / t4 /test'
This problem is the same as #31478.
I'm not sure if we need to follow this behavior or not.
There was a problem hiding this comment.
Given that GitHub has this warning, then I agree, we should implement it too.
There was a problem hiding this comment.
Both approaches sound good to me.
Both get an LGTM from me.
There was a problem hiding this comment.
I added some warnings for users similar to GitHub.
However, I have kept backend processing for spaces.
On GitHub, it only removes spaces from filenames, not from parent directories. Since Gitea can run on different operating systems, leading or trailing spaces may cause some problems. Therefore, I have retained space processing.
GiteaBot
added
lgtm/need 2
| for i, v := range treePath { | ||
| treePath[i] = strings.TrimSpace(v) | ||
| } | ||
| form.TreePath = strings.Join(treePath, "/") |
There was a problem hiding this comment.
Both approaches sound good to me.
Both get an LGTM from me.
GiteaBot
added
lgtm/need 1
charles7668
force-pushed
the
fix/new-file-space
branch
from
0c3e581
to
2543f15
Compare
pull-request-size
bot
added
size/M
close #31478