Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JS error with disabled attachment and easymde #31511

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Fix JS error with disabled attachment and easymde #31511

merged 1 commit into from
Jun 28, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Jun 27, 2024 •
edited
Loading

Not sure if this is a regression from #30513, but when attachments are disabled, this.dropzone is null and the code had failed in initEasyMDEPaste trying to access dropzoneEl.dropzone.

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 27, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 27, 2024
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jun 28, 2024 •
edited
Loading

Good catch. The first regression is #23876, the if check is also missing for long time. In 1.20 - 1.22, pasting an image also triggers JS error, while main branch makes it happen earlier (during init).

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 28, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 28, 2024
@lunny lunny merged commit 62b3738 into go-gitea:main Jun 28, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Jun 28, 2024
@wxiaoguang wxiaoguang deleted the atterr branch June 28, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@silverwind @wxiaoguang @lunny @GiteaBot