Support legacy _links LFS batch responses #31513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
wxiaoguang
reviewed
Jun 28, 2024
wxiaoguang
reviewed
Jun 28, 2024
Signed-off-by: Royce Remer <[email protected]>
rremer
force-pushed
the
main-legacy-lfs-support
branch
from
4d6ca2f
to
d58dced
Compare
|
thanks for the review @wxiaoguang , updated with your suggestions and force pushed |
wxiaoguang
approved these changes
Jun 28, 2024
GiteaBot
added
lgtm/need 1
lunny
reviewed
Jun 28, 2024
lunny
approved these changes
Jun 28, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
|
@rremer please fix the merge conflicts. 🍵 |
GiteaBot
removed
the
reviewed/wait-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support legacy _links LFS batch response.
Fixes #31512.
This is backwards-compatible change to the LFS client so that, upon mirroring from an upstream which has a batch api, it can download objects whether the responses contain the
_linksfield or its successor theactionsfield. When Gitea must fallback to the legacy_linksfield a logline is emitted at INFO level which looks like this:I've only run
test-backendwith this code, but added a new test to cover this case. Additionally I have a fork with this change deployed which I've confirmed syncs LFS from Gitea<-Artifactory (which has legacy_links) as well as from Gitea<-Gitea (which has the modernactions).