Fix markdown preview $$ support #31514
Conversation
pull-request-size
bot
added
the
size/L
GiteaBot
added
the
lgtm/need 2
|
I guess we shouldn't introduce too much copy&pasted code ........ |
charles7668
force-pushed
the
fix/support-dual-dollar-math-block
branch
from
b42d294
to
f347858
Compare
pull-request-size
bot
added
size/M
Removed some duplicate code. |
| if _, ok := n.(*InlineBlock); ok { | ||
| _, _ = w.WriteString(`<pre class="code-block is-loading"><code class="chroma language-math display">`) | ||
| } else { | ||
| _, _ = w.WriteString(`<code class="language-math is-loading">`) |
There was a problem hiding this comment.
It could be <code class="language-math is-loading {{some-extra-class-for-inline-or-not}}">
There was a problem hiding this comment.
It could be
<code class="language-math is-loading {{some-extra-class-for-inline-or-not}}">
is-loading is not a common code attribute in this case, and the class order can't be changed. If we need to change the order, we might need to update the rule in sanitizer_default.go.
There was a problem hiding this comment.
My intuition is that single <code> is good enough and more maintainable/consistent, while I won't block the two tags.
There was a problem hiding this comment.
I think the only reason for two tags is semantical correctness.
There was a problem hiding this comment.
I used two tags to keep the same style as the block render for the $$ block, but one code tag also works.
I have updated it to the one code tag version.
GiteaBot
added
lgtm/need 1
charles7668
force-pushed
the
fix/support-dual-dollar-math-block
branch
from
a288b49
to
650fbd3
Compare
charles7668
force-pushed
the
fix/support-dual-dollar-math-block
branch
from
650fbd3
to
1a85932
Compare
GiteaBot
added
lgtm/done
close #31481
currently
$$A + B$$ testwill ignore text after $$ blocktest text
before fix
after fix
github display
