Fix the shaking issue for avatars with an aspect ratio that is not 1:1.

[kerwin612]

before:

after:

[silverwind]

Hmm I'm not sure about those changes. Would like to know why it resizes in first place as I thought aspect-ratio would prevent any such resizing. Maybe you put a demo avatar on https://demo.gitea.com/ for me to investigate.

[kerwin612]

Hmm I'm not sure about those changes. Would like to know why it resizes in first place as I thought aspect-ratio would prevent any such resizing. Maybe you put a demo avatar on https://demo.gitea.com/ for me to investigate.

https://upload.wikimedia.org/wikipedia/en/3/3d/Longcat_is_loooooooooong.jpg
The image I used is for testing purposes; my environment is the latest version of Edge browser on Windows.

[kerwin612]

https://demo.gitea.com/kerwin612
It's strange that I didn't encounter the issue on the demo website.

demo: 1.23.0+dev-686-gefb55cd8ef

latest-main: 1.23.0+dev-705-gc363bd06e9

[yp05327]

I can reproduce it. So something has changed from 686 to 705.

And if you open the dev tool, then refresh the page, even in 705 it will not shake.

[yp05327]

As it works in 686, and the removed lines in this PR are not newly added codes, so I guess there's other reasons caused it.
Before we figure out it, I suggest pending giving more approves.

[wxiaoguang]

I do not think this change is right if you haven't really understood the problem.

Even without the "real" problem, is it clear about: why the width could be remove? What if there is an avatar with width=2000 and height=100?

[tboerger]

Even without the "real" problem, is it clear about: why the width could be remove? What if there is an avatar with width=2000 and height=100?

That would be fixed by a max-width attribute?