Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commit status events #33320

Merged
merged 12 commits into from
Feb 4, 2025
Merged

Fix commit status events #33320

merged 12 commits into from
Feb 4, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 18, 2025

Fix #32873
Fix #33201
Fix #33244
Fix #33302

depends on #33396

A part of this PR should be backported to v1.23 manually.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 18, 2025
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 18, 2025
@lunny lunny added type/bug backport/v1.23 This PR should be backported to Gitea 1.23 and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 18, 2025
@github-actions github-actions bot added modifies/translation modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Jan 18, 2025
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 18, 2025
lunny added a commit that referenced this pull request Jan 23, 2025
Extract from #33320

This PR uses a map instead of a struct to store webhook event
information. It removes many duplicated functions and makes the logic
clearer.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 23, 2025
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 23, 2025
@lunny lunny marked this pull request as ready for review January 23, 2025 20:38
@lunny
Copy link
Member Author

lunny commented Jan 23, 2025

This is ready to review now.

@github-actions github-actions bot removed the modifies/api This PR adds API routes or modifies them label Jan 30, 2025
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 30, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 4, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 4, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 4, 2025
@lunny lunny enabled auto-merge (squash) February 4, 2025 03:00
@lunny lunny merged commit a4676db into go-gitea:main Feb 4, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Feb 4, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 4, 2025
@lunny lunny deleted the lunny/fix_webhook branch February 4, 2025 04:48
@GiteaBot
Copy link
Collaborator

GiteaBot commented Feb 4, 2025

I was unable to create a backport for 1.23. @lunny, please send one manually. 🍵

go run ./contrib/backport 33320
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Feb 4, 2025
lunny added a commit to lunny/gitea that referenced this pull request Feb 4, 2025
Fix go-gitea#32873
Fix go-gitea#33201
~Fix go-gitea#33244~
~Fix go-gitea#33302~

depends on ~go-gitea#33396~

A part of this PR should be backported to v1.23 manually.
@lunny lunny added the backport/done All backports for this PR have been created label Feb 4, 2025
lunny added a commit that referenced this pull request Feb 5, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 5, 2025
* giteaofficial/main:
  add `timetzdata` build tag to binary releases (go-gitea#33463)
  Fix unnecessary comment when moving issue on the same project column (go-gitea#33496)
  [skip ci] Updated translations via Crowdin
  Refactor web route handler (go-gitea#33488)
  Reject star-related requests if stars are disabled (go-gitea#33208)
  Fix commit status events (go-gitea#33320)
  [skip ci] Updated translations via Crowdin
  Disable cron task to update license (go-gitea#33486)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bug
Projects
None yet
4 participants