-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check user/org repo limit instead of doer #34147
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks reasonable to me, though I'm also not an expert.
Co-authored-by: TheFox0x7 <[email protected]>
I think we need a complete fix like this: 8b48d86 Use |
And let's add some tests: c654ade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix merge conflict
This PR tries to finally fix the bug mentioned in #30011 and #15504, where the user repo limit is checked when creating a repo in an organization.
Fix #30011
Please verify that this change makes sense, I don't know a lot about the gitea codebase, so I cannot overlook the security implications that this change will have for other parts of the code.