Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): update cli Project creation succeeded prompt #3313

Closed
wants to merge 2 commits into from

Conversation

mo3et
Copy link
Contributor

@mo3et mo3et commented May 1, 2024

Description (what this PR does / why we need it):

update cli Project creation succeeded prompt.
go generate ./... ->make generate

Running Kratos run on the latest version results in issue kratos-layout#143.
I think it's a Prompt issue, I reproduce this operation using make generate, which solves issue kratos-layout#143. Because make generate includes go generate inside and solves the problem of wire generation.
but it's not perfect, it needs to work with Kratos-layout to modify the content of make Generate.

For example, you need to add go mod tidy. at the end of make Generate again to make it work.

Meanwhile, I'll request the issue requester to create the corresponding PR, or I'll create one.

Which issue(s) this PR fixes (resolves / be part of):

resolves kratos-layout#143

Other special notes for the reviewers:

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.44%. Comparing base (d0d5761) to head (5a8d8ff).
Report is 1 commits behind head on main.

❗ Current head 5a8d8ff differs from pull request most recent head f851704. Consider uploading reports for the commit f851704 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3313      +/-   ##
==========================================
+ Coverage   81.83%   84.44%   +2.61%     
==========================================
  Files          92       89       -3     
  Lines        4205     4064     -141     
==========================================
- Hits         3441     3432       -9     
+ Misses        582      450     -132     
  Partials      182      182              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mo3et
Copy link
Contributor Author

mo3et commented Jun 5, 2024

@demoManito Can you review to this PR? If you think it is unnecessary, I will close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to run go generate ./... after created a project with kratos new
2 participants