Skip to content

feat: adding client stream middleware #3512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: adding client stream middleware #3512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df193b4
feat: adding client stream middleware
fzdwx Jan 6, 2025
3d5daf9
chore: add test case
fzdwx Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions transport/grpc/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,13 @@ func WithMiddleware(m ...middleware.Middleware) ClientOption {
}
}

// WithStreamMiddleware with client stream middleware.
func WithStreamMiddleware(m ...middleware.Middleware) ClientOption {
return func(s *clientOptions) {
s.streamMiddleware = m
}
}

// WithDiscovery with client discovery.
func WithDiscovery(d registry.Discovery) ClientOption {
return func(o *clientOptions) {
Expand Down
11 changes: 11 additions & 0 deletions transport/grpc/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,17 @@ func TestWithMiddleware(t *testing.T) {
}
}

func TestWithStreamMiddleware(t *testing.T) {
o := &clientOptions{}
v := []middleware.Middleware{
func(middleware.Handler) middleware.Handler { return nil },
}
WithStreamMiddleware(v...)(o)
if !reflect.DeepEqual(v, o.streamMiddleware) {
t.Errorf("expect %v but got %v", v, o.streamMiddleware)
}
}

type mockRegistry struct{}

func (m *mockRegistry) GetService(_ context.Context, _ string) ([]*registry.ServiceInstance, error) {
Expand Down
Loading