feat: expose task's exit code to env var 'DEFER_EXIT_CODE' #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update documentation for DEFER_EXIT_CODE
dorimon-1
force-pushed
the
expose_exit_code
branch
from
23e29a8
to
9be807e
Compare
Merge from main
pd93
reviewed
Jun 7, 2024
pd93
reviewed
Jun 7, 2024
Revert "remove package-lock.json" This reverts commit 2409637. remove package-lock
dorimon-1
force-pushed
the
expose_exit_code
branch
from
97a6ebf
to
4b91a54
Compare
andreynering
requested changes
Jun 14, 2024
There was a problem hiding this comment.
Hi @dorimon-1. Thanks for your pull request, it is much appreciated!
I'm requesting changes EXIT_CODE should be a regular variable and not an environment variable. This would make it consistent with the other special variables.
Hi, thanks for your comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1484
Exposes environment variable DEFER_EXIT_CODE once a task is finished, to allow you to use it in defer statements.
In case there was an error (exit code != 0), it wont be overridden by a successful task, but it will be overridden when a different task fails with a different code.