Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2073
Removes
zglob
as a dependency and instead relies on mvdan'sexpand.Fields
with globbing turned on forsources
globs.We also use
expand.Fields
in multiple other places to resolve things like~
and environment variables. However, most of the time, we don't also want brace expansion or globbing, so I have separated this into two functions. One wrapsexpand.Literal
which returns a single string with just the variables resolved, and the other wrapsexpand.Fields
with braces and globbing enabled.