[shaping] Trailing spaces

[benoitkugler]

Due to a missing reference operator (&), the trailing whitespaces were not collapsed properly.

An interesting side effect of this change was to discover that some tests used one Output several times, without copying its glyphs, leading to spurious errors when the glyphs were mutated.

[andydotxyz]

I don't fully understand the ramification around the copy but this seems sensible.

[benoitkugler]

I don't fully understand the ramification around the copy but this seems sensible.

Some tests use the same Output as input value for line wrapping, mutating this input, so that the next test has an input which is not the one we intended. In pseudo code, this is :

input := Output{...}
result1 := LineWrap(input, settings1) // woups, we are actually mutating the input glyph slice
result2 := LineWrap(input, settings2) // test failed, since input has changed

[benoitkugler]

I'll go ahead and merge, since this is a bug fix with no external API change.

[whereswaldon]

Thanks @benoitkugler !