[shaping] add support for custom letter and word spacing #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whereswaldon
requested changes
May 16, 2024
There was a problem hiding this comment.
Thanks @benoitkugler, this looks great! I have a very minor request.
Co-authored-by: Chris Waldon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a revisited version of #90.
The proposed API consists of two methods
Output.AddWordSpacing()andOutput.AddLetterSpacing()and a convenient functionAddSpacingaccepting a slice ofOutputs.I've exported the
Outputmethods so that it may be used by external implementation ofRunIterator.Implementation note : by registering the letter spacing in a new
Glyphfield, the line wrapper is able to trim edge spacing on its own, without requiring the user to "clean up" the runs after wrapping.What do you think ?