refactor: describe stacks for client (#126)

go-to-k · Mar 9, 2023 · 52417e1 · 52417e1
1 parent a099d3d
commit 52417e1
Show file tree

Hide file tree

Showing 5 changed files with 436 additions and 388 deletions.
diff --git a/internal/operation/cloudformation_stack.go b/internal/operation/cloudformation_stack.go
@@ -102,36 +102,36 @@ func (o *CloudFormationStackOperator) DeleteCloudFormationStack(ctx context.Cont
 }
 
 func (o *CloudFormationStackOperator) deleteStackNormally(ctx context.Context, stackName *string, isRootStack bool) (bool, error) {
-	stackOutputBeforeDelete, stackExistsBeforeDelete, err := o.client.DescribeStacks(ctx, stackName)
+	stacksBeforeDelete, err := o.client.DescribeStacks(ctx, stackName)
 	if err != nil {
 		return false, err
 	}
-	if !stackExistsBeforeDelete && isRootStack {
+	if len(stacksBeforeDelete) == 0 && isRootStack {
 		errMsg := fmt.Sprintf("%s stack not found.", *stackName)
 		return false, fmt.Errorf("NotExistsError: %v", errMsg)
 	}
-	if !stackExistsBeforeDelete {
+	if len(stacksBeforeDelete) == 0 {
 		return true, nil
 	}
 
-	if *stackOutputBeforeDelete.Stacks[0].EnableTerminationProtection {
+	if stacksBeforeDelete[0].EnableTerminationProtection != nil && *stacksBeforeDelete[0].EnableTerminationProtection {
 		return false, fmt.Errorf("TerminationProtectionIsEnabled: %v", *stackName)
 	}
 
 	if err := o.client.DeleteStack(ctx, stackName, []string{}); err != nil {
 		return false, err
 	}
 
-	stackOutputAfterDelete, stackExistsAfterDelete, err := o.client.DescribeStacks(ctx, stackName)
+	stacksAfterDelete, err := o.client.DescribeStacks(ctx, stackName)
 	if err != nil {
 		return false, err
 	}
-	if !stackExistsAfterDelete {
+	if len(stacksAfterDelete) == 0 {
 		io.Logger.Info().Msg("No resources were DELETE_FAILED.")
 		return true, nil
 	}
-	if stackOutputAfterDelete.Stacks[0].StackStatus != "DELETE_FAILED" {
-		return false, fmt.Errorf("StackStatusError: StackStatus is expected to be DELETE_FAILED, but %v: %v", stackOutputAfterDelete.Stacks[0].StackStatus, *stackName)
+	if stacksAfterDelete[0].StackStatus != "DELETE_FAILED" {
+		return false, fmt.Errorf("StackStatusError: StackStatus is expected to be DELETE_FAILED, but %v: %v", stacksAfterDelete[0].StackStatus, *stackName)
 	}
 
 	return false, nil