Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PD to ignore reply from other PD on same address #112

Conversation

schmida2
Copy link
Contributor

@schmida2 schmida2 commented May 3, 2023

For OSDP auto addressing (https://github.com/schmida2/libosdp/blob/osdp-extension-autoaddr/OSDP_Extension-AutoAddressingProtocol.md) it happens that initially multiple PDs linger on the same bus address.
This change ensures that PDs do not react to a reply from another PD on the same address.
This change does not harm "normal" bus operation; it adds some robustness for unusual cases.

@sidcha
Copy link
Member

sidcha commented Oct 11, 2023

@schmida2 I will close this PR for now; let's discuss on #113 and then come back implementation.

At the very least, any non-standard changes should be guarded by feature flags where the user has to opt-in for this behaviour.

@sidcha sidcha closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants