Python Bindings: CP add CMD_STATUS support #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Stuckya
commented
May 19, 2023
| @@ -363,7 +363,11 @@ static int pyosdp_make_struct_cmd_file_tx(struct osdp_cmd *p, PyObject *dict) | |||
| } | |||
|
|
|||
| /* Dummies for commands that don't have any body */ | |||
| static int pyosdp_make_struct_cmd_dummy(struct osdp_cmd *cmd, PyObject *obj) { return 0; } | |||
| static int pyosdp_make_struct_cmd_dummy(struct osdp_cmd *cmd, PyObject *obj) { | |||
There was a problem hiding this comment.
This appears to be the only usage of this function. Should we rename the function and update the comment since it has a body now?
There was a problem hiding this comment.
No, the issue is because we are setting cmd->id in the wrong place. The caller pyosdp_make_struct_cmd should set it so the dummy can stay as it is now.
|
@Stuckya You can fix this if you are up for it. If not, I will close this PR and fix it myself in a couple of days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an incompatibility when trying to use some new functionality in the Python bindings: #105
Currently
osdp.CMD_STATUSis not exposed to the user of the Python bindings.Additionally, the evaluated enum value is discarded by
pyosdp_make_struct_cmd_dummy.