Add support for additional baud rate 57600 #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidcha
requested changes
Jun 13, 2023
osdpctl/cmd_send.c
Outdated
Comment on lines
199
to
200
| if (baud != 9600 && baud != 19200 && baud != 38400 && baud != 57600 && | ||
| baud != 115200 && baud != 230400) |
There was a problem hiding this comment.
The coding style we follow requires the multi-line if conditions to align to the next char after the opening bracket '('. So the hunk above becomes:
Suggested change
| if (baud != 9600 && baud != 19200 && baud != 38400 && baud != 57600 && | |
| baud != 115200 && baud != 230400) | |
| if (baud != 9600 && baud != 19200 && baud != 38400 && baud != 57600 && | |
| baud != 115200 && baud != 230400) |
(Same change to the other hunk as well)
There was a problem hiding this comment.
OK, sorry. Tabs in my IDE is 4 spaces equivalent, I didn't notice it ^^. PR updated according your review. Thanks for your great job :)
sgouraud
force-pushed
the
baudrate-enhancement
branch
from
eccb238
to
c53515f
Compare
sgouraud
force-pushed
the
baudrate-enhancement
branch
from
c53515f
to
4bcfd2d
Compare
sidcha
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According specification, half-duplex asynchronous serial should support at least one of 9600, 19200, 38400, 57600, 115200, 230400 Baud. Adding support for 57600.