Added prototypes for implicitly declared functions in osdp_phy.c #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Prototypes for implicitly declared functions
sidcha
reviewed
Jun 13, 2023
Comment on lines
+370
to
+376
| //ADDED PROTOTYPES for implicitly declared functions | ||
| int osdp_channel_receive(struct osdp_pd *pd); | ||
| int get_tx_buf_size(struct osdp_pd *pd); | ||
| int osdp_phy_send_packet(struct osdp_pd *pd, const uint8_t *buf, int len, int buf_size); | ||
| int phy_check_header(struct osdp_pd *pd); | ||
| int osdp_rb_pop_buf(struct osdp_rb *rb, const uint8_t *max_len, int min_len); //Note: probably needs more useful variable names | ||
| int phy_check_packet(struct osdp_pd *pd, const uint8_t *buf, int len); |
There was a problem hiding this comment.
Those are all static methods which should not be exported here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Prototypes for implicitly declared functions