Feature/gcc warning errors #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! PRs are most welcome and I will be happy to merge any patch that fixes issues in any platform (which looks to be the case here). In this case, can you please create separate PR in utils submodule first and then update this PR with the submodule bump commit here after the utils changes are merged. |
sidcha
reviewed
Nov 6, 2023
src/osdp_common.c
Outdated
Comment on lines
6
to
8
| #ifndef _GNU_SOURCE | ||
| #define _GNU_SOURCE /* See feature_test_macros(7) */ | ||
| #endif |
There was a problem hiding this comment.
As mentioned in goToMain/c-utils#23, I think we can drop this. Please give it a try and update this PR.
.gitmodules
Outdated
| @@ -1,3 +1,3 @@ | |||
| [submodule "utils"] | |||
| path = utils | |||
| url = https://github.com/goToMain/c-utils.git | |||
| url = https://github.com/badevos/c-utils.git | |||
There was a problem hiding this comment.
You have to drop this change. You must add a submodule bump commit (after goToMain/c-utils#23 has been merged) instead.
With gcc 8.4.0 the following warning was thrown: src/osdp_common.c:7: warning: "_GNU_SOURCE" redefined #define _GNU_SOURCE /* See feature_test_macros(7) */ As the application defines using _GNU_SOURCE or not it's safe to conditionally set this macro
badevos
force-pushed
the
feature/gcc-warning-errors
branch
from
7491610
to
f8d6c71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm trying to integrate your library into another project using gcc 8.4.0 with '-Werror'. This gives some small issues. Would it be possible to integrate my changes?
This affects both the library as items into your submodule 'utils'. I create a separate pull request for that.
Logically you can skip the changes to link to my fork, but this allows me to do a full integration myself.
In case you accept my changes I can safely use the upstream version.
Let me know your thoughts.
Thanks in advance.
Kr,
Bart.