Develop #144
Merged
Develop #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… places where you need to pass class object
…y the default state of PD
sidcha
reviewed
Nov 30, 2023
src/osdp_cp.c
Outdated
Comment on lines
1389
to
1394
| case OSDP_CMD_OUT_STATUS: | ||
| cmd_id = CMD_OSTAT; | ||
| break; | ||
| case OSDP_CMD_INPUT_STATUS: | ||
| cmd_id = CMD_ISTAT; | ||
| break; |
There was a problem hiding this comment.
The output/input status have to be handled along with case OSDP_CMD_STATUS: above to avoid having to introduced too many command types. Also I think some refactoring around this area is overdue.
Please drop this change, I will take address it shortly.
|
Thanks for the PR. I squash merged your change to minimize git log noise. |
|
@mehmoodmalik I added the status query feature that you were interested in e2d2c03. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I am currently developing OSDP product using your library. I faced the following issues:
1- I was unable to pass a class object to the PD callback, I noticed that instead of passing args you are just passing _ctx which doesn't make any sense to me. That is why i added the args in the set_command_callback of PD.
2- It is enough to declare _ctx = nullptr at Common class because each derived class would call the constructor of Common and it will initialize the _ctx to nullptr.
3- Exposing ISTAT and OSTAT to application level. I faced a situation where ACU need to know the default state of the PD.
Please have a look to my changes i am waiting for this to be merged so that we can utilize this code in our company.
Best regards,
Mehmood Malik.