Increasing the max data contained in an OSDP event to 128bytes #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Won't this greatly increase memory consumption? If so, I don't think this would be a good default then. |
|
@Sympatron, I was aware of this when I merged the change. I wasn't worried because that whole issue is due to a relic design decision of having internal and external command use the same structure. I plan on spending some time to decouple those two and then |
sidcha
added a commit
that referenced
this pull request
Jan 6, 2024
Since we bumped the size of event data len to 128 in #152, the command/event pool size of 32 uses almost 4KiB of RAM. To fix this CP state machine was completely rewritten to not use the command queue entirely. With this change, the command/event queue is exclusively meant for commands and events sent from the application to libosdp and does not need to be as large as 32. Reduce this queue size to 4 -- thereby reducing the total memory used to just 512 bytes. Signed-off-by: Siddharth Chandrasekaran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary because we are dealing with a Manufacturer Specific Response that contains at least 73 bytes of date. The data is an ASN.1 serialized ECDSA P256 signature. In the case of larger curves (e.g. P384) the signature will be longer but 128 bytes will handle it fine. In the case of RSA signatures it is almost for sure that 128bytes will be too small but that is not a use case we are concerned with at the moment nor is it one we can test.