Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression in Rust binding. Commit 51b626c94bc39242f9793c916471bd… #156

Merged
merged 3 commits into from
Jan 14, 2024
Merged

Fix regression in Rust binding. Commit 51b626c94bc39242f9793c916471bd… #156

merged 3 commits into from
Jan 14, 2024

Conversation

jr-oss
Copy link
Contributor

@jr-oss jr-oss commented Jan 14, 2024

…adafe24679 increased buffer size to 128 bytes. Adjust binding accordingly.

@jr-oss
Copy link
Contributor Author

jr-oss commented Jan 14, 2024

Would it be better to change the sizes this way:?

let mut data = [0; libosdp_sys::OSDP_EVENT_MFGREP_MAX_DATALEN as usize];

I could change the PR to do this for events and commands (3 changes each).

@sidcha
Copy link
Member

sidcha commented Jan 14, 2024

Yes, that would be better.

sidcha
sidcha approved these changes Jan 14, 2024
View reviewed changes
Copy link
Member

@sidcha sidcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@sidcha sidcha merged commit 9eea249 into goToMain:master Jan 14, 2024
10 checks passed
@jr-oss jr-oss deleted the rust_regreesion_buffer_size branch January 14, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidcha sidcha sidcha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jr-oss @sidcha