Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue normally on successful command callback on status commands #174

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

KaiAmelung
Copy link
Contributor

Seems like this is just a typo to me, unless I do not understand. Not sure why we would want to "fail to decode" when the command callback returns successfully.

Was noticing this:

reading: ffffffff5300080006676ebc (this log is from SerialChannel)
OSDP: PD-0: [2024-04-12T22:55:12Z] [WARN ] vendor/src/osdp_phy.c:521: Packet scan skipped 3 bytes before SoM
command received (from command callback)
OSDP: PD-0: [2024-04-12T22:55:12Z] [ERROR] vendor/src/osdp_pd.c:661: Failed to decode command: CMD(67) Len:0 ret:-2
OSDP: PD-0: [2024-04-12T22:55:12Z] [DEBUG] vendor/src/osdp_pd.c:669: CMD: RSTAT(67) REPLY: NAK(41)
writing: ff5380090006410224fa (this log is from SerialChannel)

when using a basic command callback like this (in Python):

def handle_command(self, command):
        print('command received')
        return 0, None

Copy link
Member

@sidcha sidcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks like a typo and seems like there is a testing gap too, will create an issue to track it. Thanks for the fix.

@sidcha sidcha merged commit 5f66b53 into goToMain:master Apr 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants