-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
web: fix notification count update #15796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-integrations canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15796 +/- ##
==========================================
+ Coverage 93.17% 93.22% +0.04%
==========================================
Files 831 831
Lines 44251 44251
==========================================
+ Hits 41230 41252 +22
+ Misses 3021 2999 -22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I was thinking about this pr again. In |
|
@macmoritz Thanks for being so patient on this bug. The notifications drawer has recently been refactored to cover this issue, along with a few related front-end synchronization issues. You can track the progress of these fixes (along with your initial commit 😊) in the #19141 merge branch. |
|
Sounds great! |
Details
The notification count in the navigation bar was out of sync. This pr fixes this to be adjusted in real time.
The sync issues where noticeable by using the notification drawer to mark notifications seen.
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make docs)