Skip to content

Conversation

@macmoritz
Copy link
Contributor

Details

The notification count in the navigation bar was out of sync. This pr fixes this to be adjusted in real time.
The sync issues where noticeable by using the notification drawer to mark notifications seen.

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make docs)

@macmoritz macmoritz requested a review from a team as a code owner July 25, 2025 23:47
@netlify
Copy link

netlify bot commented Jul 25, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit c76cd56
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/68841786c185cf000954bd82
😎 Deploy Preview https://deploy-preview-15796--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jul 25, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit c76cd56
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/688417867dc05100080d54c1
😎 Deploy Preview https://deploy-preview-15796--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jul 25, 2025

Deploy Preview for authentik-integrations canceled.

Name Link
🔨 Latest commit c76cd56
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/688417860feee500073df656

@codecov
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.22%. Comparing base (ca75862) to head (c76cd56).
⚠️ Report is 1997 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15796      +/-   ##
==========================================
+ Coverage   93.17%   93.22%   +0.04%     
==========================================
  Files         831      831              
  Lines       44251    44251              
==========================================
+ Hits        41230    41252      +22     
+ Misses       3021     2999      -22     
Flag Coverage Δ
e2e 46.64% <ø> (+0.07%) ⬆️
integration 23.46% <ø> (+<0.01%) ⬆️
unit 91.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@macmoritz
Copy link
Contributor Author

I was thinking about this pr again. In web/src/user/index.entrypoint.ts the notification count gets only passed to the ak-nav-buttons element.
How about removing this redundancy and directly registering a listener on EVENT_REFRESH in the ak-nav-buttons element?
The listener is needed to update the notification count preview in the navigation bar.

@GirlBossRush
Copy link
Contributor

@macmoritz Thanks for being so patient on this bug. The notifications drawer has recently been refactored to cover this issue, along with a few related front-end synchronization issues.

You can track the progress of these fixes (along with your initial commit 😊) in the #19141 merge branch.

@macmoritz
Copy link
Contributor Author

Sounds great!
Thanks for recycling my commit.
Lets close this PR in favor of #19141.

@macmoritz macmoritz closed this Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants