-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
sources/ldap: implement nested group parentship sync #19069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
sources/ldap: implement nested group parentship sync #19069
Conversation
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19069 +/- ##
==========================================
- Coverage 93.12% 93.11% -0.02%
==========================================
Files 949 949
Lines 52419 52470 +51
==========================================
+ Hits 48813 48855 +42
- Misses 3606 3615 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
website/docs/users-sources/sources/directory-sync/active-directory/index.md
Show resolved
Hide resolved
|
Before we do any of that, I want us to actually use the Also, cc. @gergosimonyi |
Do you want me to change how I handle it then @risson? I read the definitions in main so far and it seems pretty straight-forward to me. Unless someone is working on it already (iykyk @dominic-r), I might be able to update the entire sync process, in a separate MR. |
I think it makes sense to do that part in a separate PR first, and then build on top of that for this PR.
I don't think anyone is currently working on this specific part. |
Also added better descriptions to all relevant fields, explaining how they interact with each other.
f648505 to
8fe972b
Compare
Details
Release 2025.12 brought many-to-many group inheritance. This PR builds on that, and adds true nested group synchronisation from LDAP.
LDAPSourcemodel fields were renamed to reflect this, and membership sync now runs through both user and group objects in LDAP reflects directory inheritance structure in Authentik.If accepted, this PR resolves #9460.
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make docs)To review / suggest
group_membership_field-->membership_fielduser_membership_attribute-->membership_referencesync_parent_group-->additional_parent_grouplookup_groups_from_user-->lookup_groups_from_member