core: make trailing slash optional for flow URLs #19091
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #19091 +/- ##
===========================================
- Coverage 93.37% 83.28% -10.10%
===========================================
Files 949 949
Lines 52254 52254
===========================================
- Hits 48794 43520 -5274
- Misses 3460 8734 +5274
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
The required trailing slash is likely inconsequential in the majority of cases, however specifically when bootstrapping the project and using
/if/flow/initialsetup/it seems there are many people including myself (see this comment) that have mistakenly not included the trailing slash and are not used to the URLs/if/flow/initialsetupand/if/flow/initialsetup/being handled differently.This change is made by swapping path() to re_path() to regex the pattern with and without the trailing slash.
It is worth mentioning that this is essentially the default behavior with APPEND_SLASH=True but this was previously disabled for other reasons (#6928).
Checklist
ak test authentik/)make lint-fix)