stages/authenticator_static: set max token length to 100 chars #19162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominic-r
added
area:frontend
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19162 +/- ##
==========================================
+ Coverage 93.15% 93.35% +0.20%
==========================================
Files 949 949
Lines 52384 52385 +1
==========================================
+ Hits 48797 48904 +107
+ Misses 3587 3481 -106
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kensternberg-authentik
approved these changes
Jan 2, 2026
web/src/admin/stages/authenticator_static/AuthenticatorStaticStageForm.ts
Outdated
Show resolved
Hide resolved
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-b0a1c75c0ab3de691e42fe106835bc461a22ad56
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-b0a1c75c0ab3de691e42fe106835bc461a22ad56Afterwards, run the upgrade commands from the latest release notes. |
gergosimonyi
reviewed
Jan 4, 2026
Collaborator
gergosimonyi
left a comment
gergosimonyi
left a comment
There was a problem hiding this comment.
Recommendation: instead, the database should accept tokens up to length n where n is way greater than 16 and, let's say, at least 43. With the current [0-9a-zA-Z] alphabet that would give log_2(62^43)≈256 bits of entropy for anyone who wants that.
dominic-r
added
the
backport/version-2025.12
dominic-r
changed the title
dominic-r
changed the title
dominic-r
changed the title
gergosimonyi
approved these changes
Jan 7, 2026
authentik-automation bot
pushed a commit
that referenced
this pull request
Jan 7, 2026
* stages/authenticator_static: add max length validation for token_length field * wip * wip
Contributor
|
🍒 Cherry-pick to |
rissson
pushed a commit
that referenced
this pull request
Jan 8, 2026
…y-pick #19162 to version-2025.12) (#19231) Co-authored-by: Dominic R <[email protected]>
kensternberg-authentik
added a commit
that referenced
this pull request
Jan 8, 2026
* main: stages/prompt: optimize API endpoints (#19251) web: bump the rollup group across 1 directory with 4 updates (#19206) web: bump vite from 7.3.0 to 7.3.1 in /web (#19245) website/docs: update github social login script example (#19246) website/integrations: update AWS (#17861) core: bump goauthentik.io/api/v3 from 3.2026020.8 to 3.2026020.10 (#19242) website: Fix typos. (#19243) core: fix read replica routing during transactions (#19086) website/glossary: improve (#18969) stages/authenticator_static: set max token length to 100 chars (#19162)
kensternberg-authentik
added a commit
that referenced
this pull request
Jan 12, 2026
* main: (44 commits) web: Fix flow inspector advancement event. (#19309) web: bump knip from 5.80.0 to 5.80.1 in /web (#19301) core: bump urllib3 from 2.5.0 to v2.6.3 (#19287) endpoints: show agent version (#19239) core: bump django from v5.2.9 to 5.2.10 (#19290) web/admin: add banner to flow import form (#19288) web: bump chromedriver from 143.0.3 to 143.0.4 in /web (#19244) stages/password: replace session-based retries with reputation (#18643) website/integations: fix aws spelling (#19253) website/docs: update entra id provider docs (#18366) stages/prompt: optimize API endpoints (#19251) web: bump the rollup group across 1 directory with 4 updates (#19206) web: bump vite from 7.3.0 to 7.3.1 in /web (#19245) website/docs: update github social login script example (#19246) website/integrations: update AWS (#17861) core: bump goauthentik.io/api/v3 from 3.2026020.8 to 3.2026020.10 (#19242) website: Fix typos. (#19243) core: fix read replica routing during transactions (#19086) website/glossary: improve (#18969) stages/authenticator_static: set max token length to 100 chars (#19162) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets maximum static token length to 100 cause of some math Gergo did. Also adds a validator and gives the max value to the user in the ui. slightly improves/tweaks the UI to wrap on long tokens and render one per line.
ui snapshots:
50:
16:
Closes: #19158