Skip to content

core: handle deserialization errors from FileField migration (cherry-pick #19067 to version-2025.12) #19168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rissson merged 2 commits into from
Jan 6, 2026
Merged

core: handle deserialization errors from FileField migration (cherry-pick #19067 to version-2025.12) #19168

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
430c571
core: handle deserialization errors from FileField migration (#19067)
dominic-r Jan 3, 2026
c1e6669
Merge branch 'version-2025.12' into cherry-pick/19067-to-version-2025.12
dominic-r Jan 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions authentik/core/sessions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,12 @@ def encode(self, session_dict):
def decode(self, session_data):
try:
return pickle.loads(session_data) # nosec
except pickle.PickleError:
# ValueError, unpickling exceptions. If any of these happen, just return an empty
# dictionary (an empty session)
except (pickle.PickleError, AttributeError, TypeError):
# PickleError, ValueError - unpickling exceptions
# AttributeError - can happen when Django model fields (e.g., FileField) are unpickled
# and their descriptors fail to initialize (e.g., missing storage)
# TypeError - can happen with incompatible pickled objects
# If any of these happen, just return an empty dictionary (an empty session)
pass
return {}

Expand Down
Loading