web: Clean up prefixed debugging logs #19185
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
GirlBossRush
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19185 +/- ##
==========================================
+ Coverage 93.15% 93.34% +0.18%
==========================================
Files 949 949
Lines 52254 52254
==========================================
+ Hits 48676 48774 +98
+ Misses 3578 3480 -98
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-4575369c1469f465c6f749ef3a8be94de55b9421
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-4575369c1469f465c6f749ef3a8be94de55b9421Afterwards, run the upgrade commands from the latest release notes. |
GirlBossRush
force-pushed
the
better-browser-logging
branch
from
4575369 to
2c813cb
Compare
Contributor
Author
|
Resolved via #19141 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
tl;dr Fewer
console.debug.bindand copy-pasted log prefix strings.This PR updates our logging approach in the frontend codebase by replacing multiple instances of
console.debug.bind(console, "some-component")with an instance of browser-compatibleConsoleLoggerstatic class. Similar to our Pino-based logger in Node.js, this class allows us to create prefixed loggers for different components without the ceremony of function binding.The motivation behind this came about while debugging Lit's context event system. The goal was to have consistent logging across the codebase that can be easily toggled or filtered in the same API style as our Node.js logging. The browser
ConsoleLoggeris a step in that direction, providing a familiar interface for logging in the frontend.Dependents