Skip to content

web: Defer table refresh, visibility checks. #19194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GirlBossRush merged 1 commit into from
Jan 5, 2026
Merged

web: Defer table refresh, visibility checks. #19194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions web/src/elements/ak-progress-bar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,19 +64,19 @@ export class ProgressBar extends AKElement {
`,
];

@property({ type: Number })
@property({ type: Number, reflect: true, useDefault: true })
public min = 0;

@property({ type: Number })
@property({ type: Number, reflect: true, useDefault: true })
public max = 100;

@property({ type: Number })
@property({ type: Number, reflect: true, useDefault: true })
public value = 0;

@property({ type: Boolean })
@property({ type: Boolean, reflect: true, useDefault: true })
public indeterminate = false;

@property({ type: String })
@property({ type: String, reflect: true, useDefault: true })
public size: PFSize = PFSize.Medium;

@property({ type: String })
Expand Down Expand Up @@ -105,7 +105,7 @@ export class ProgressBar extends AKElement {
`
: nothing}
<div
class="pf-c-progress__bar"
class="pf-c-progress__bar ak-fade-in"
role="progressbar"
aria-valuemin=${this.min}
aria-valuemax=${this.max}
Expand Down
6 changes: 3 additions & 3 deletions web/src/elements/forms/DeleteBulkForm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { SlottedTemplateResult } from "#elements/types";
import { UsedBy, UsedByActionEnum } from "@goauthentik/api";

import { msg, str } from "@lit/localize";
import { CSSResult, html, nothing, TemplateResult } from "lit";
import { CSSResult, html, nothing, PropertyValues, TemplateResult } from "lit";
import { customElement, property, state } from "lit/decorators.js";
import { until } from "lit/directives/until.js";

Expand Down Expand Up @@ -79,9 +79,9 @@ export class DeleteObjectsTable<T extends object> extends Table<T> {
return nothing;
}

firstUpdated(): void {
firstUpdated(changedProperties: PropertyValues<this>): void {
this.expandable = this.usedBy !== undefined;
super.firstUpdated();
super.firstUpdated(changedProperties);
}

renderExpanded(item: T): TemplateResult {
Expand Down
1 change: 1 addition & 0 deletions web/src/elements/table/Table.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ time {
}

:host {
display: block;
Copy link
Contributor Author

@GirlBossRush GirlBossRush Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensures that the intersection observer can measure the threshold accurately.

container-type: inline-size;
}

Expand Down
Loading
Loading