Skip to content

Conversation

@GirlBossRush
Copy link
Contributor

@GirlBossRush GirlBossRush commented Jan 7, 2026

Details

 ╭┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄╮
 ┆ This PR is a merge branch! ┆
 ╰┄┄┄┄┄┄┄┄┄┬┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄╯

            ╱╲ ╱╲ 
          ╱ ̄(°㇀°⚟) ̄╱╲
         ╱┌──じ㇀し───┐╲╱
          │          │
          │      ǝpoɔ│ ╱
          └─────┄───┄

How to review

This PR is split into separate topics to make the changes more digestable:

@GirlBossRush GirlBossRush requested a review from a team as a code owner January 7, 2026 21:13
@netlify
Copy link

netlify bot commented Jan 7, 2026

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 8a64762
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/69612ceb8fd4d100087175ff
😎 Deploy Preview https://deploy-preview-19229--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 7, 2026

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 8a64762
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/69612ceb21610a0008d599a2
😎 Deploy Preview https://deploy-preview-19229--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment on lines -77 to +81
this.#locale = event.detail.readyLocale;
this.#locale = formatAcceptLanguageHeader(event.detail.readyLocale);
};

constructor(localeHint?: string) {
this.#locale = autoDetectLanguage(localeHint);
constructor(languageTagHint: Intl.UnicodeBCP47LocaleIdentifier) {
this.#locale = formatAcceptLanguageHeader(languageTagHint);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g.

accept-language: ja-JP, en-US;q=0.8, en;q=0.5, *;q=0.3

Comment on lines -201 to 203
export function renderLocaleDisplayNames(
entries: LocaleDisplay[],
activeLocaleTag: TargetLanguageTag | null,
export function formatRelativeLocaleDisplayName(
languageTag: TargetLanguageTag,
localizedDisplayName: string,
relativeDisplayName: string,
) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split the render function from the formatter logic to re-use in the locale stage prompt component.

Comment on lines -160 to +161
* @param localeHint An optional locale code hint.
* @param fallbackLocaleCode An optional fallback locale code.
* @param languageTagHint An optional locale code hint.
* @param fallbackLanguageTag An optional fallback locale code.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistent usage of "language tag" (a string) vs locale (a JavaScript Locale object)

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.36%. Comparing base (caa4826) to head (8a64762).
⚠️ Report is 74 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19229      +/-   ##
==========================================
+ Coverage   93.12%   93.36%   +0.24%     
==========================================
  Files         949      949              
  Lines       52419    52419              
==========================================
+ Hits        48813    48942     +129     
+ Misses       3606     3477     -129     
Flag Coverage Δ
conformance 38.78% <ø> (+<0.01%) ⬆️
e2e 44.67% <ø> (+1.27%) ⬆️
integration 23.42% <ø> (+<0.01%) ⬆️
unit 91.58% <ø> (+0.02%) ⬆️
unit-migrate 91.63% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GirlBossRush GirlBossRush force-pushed the 2025-12-release-fixes-v4 branch from 076db76 to 603aec0 Compare January 7, 2026 21:22
self.navigator?.language,
fallbackLocaleCode,
languageTagHint,
...(self.navigator?.languages || []),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GirlBossRush GirlBossRush force-pushed the 2025-12-release-fixes-v4 branch 2 times, most recently from 8430670 to 8635d44 Compare January 7, 2026 21:26
Comment on lines 150 to 151
<path
d="M27.85 29H30l-6-15h-2.35l-6 15h2.15l1.6-4h6.85Zm-7.65-6 2.62-6.56L25.45 23ZM18 7V5h-7V2H9v3H2v2h10.74a14.7 14.7 0 0 1-3.19 6.18A13.5 13.5 0 0 1 7.26 9h-2.1a16.5 16.5 0 0 0 3 5.58A16.8 16.8 0 0 1 3 18l.75 1.86A18.5 18.5 0 0 0 9.53 16a16.9 16.9 0 0 0 5.76 3.84L16 18a14.5 14.5 0 0 1-5.12-3.37A17.64 17.64 0 0 0 14.8 7Z"
d="M16 2a14 14 0 1 0 14 14A14 14 0 0 0 16 2m12 13h-6a24.26 24.26 0 0 0-2.79-10.55A12 12 0 0 1 28 15M16 28a5 5 0 0 1-.67 0A21.85 21.85 0 0 1 12 17h8a21.85 21.85 0 0 1-3.3 11 5 5 0 0 1-.7 0m-4-13a21.85 21.85 0 0 1 3.3-11 6 6 0 0 1 1.34 0A21.85 21.85 0 0 1 20 15Zm.76-10.55A24.26 24.26 0 0 0 10 15H4a12 12 0 0 1 8.79-10.55ZM4.05 17h6a24.26 24.26 0 0 0 2.75 10.55A12 12 0 0 1 4.05 17m15.16 10.55A24.26 24.26 0 0 0 22 17h6a12 12 0 0 1-8.79 10.55"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow up to UI feedback, swapping this to Carbon's globe icon.

className?: string,
): SlottedTemplateResult {
if (!imagePath) {
export const ThemedImage: LitFC<ThemedImageProps> = ({ src, className, theme, ...props }) => {
Copy link
Contributor Author

@GirlBossRush GirlBossRush Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworked to usage of rootInterface, which may flicker or have stale values when the chosen color scheme changes.

@GirlBossRush GirlBossRush force-pushed the 2025-12-release-fixes-v4 branch from 8635d44 to da8c4ba Compare January 7, 2026 23:42
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-8a64762dd62fc410384b322f2739b5836f26a635
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-8a64762dd62fc410384b322f2739b5836f26a635

Afterwards, run the upgrade commands from the latest release notes.

@GirlBossRush GirlBossRush force-pushed the 2025-12-release-fixes-v4 branch from da8c4ba to 024def4 Compare January 8, 2026 00:29
@GirlBossRush GirlBossRush requested a review from a team as a code owner January 8, 2026 00:29
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

authentik translations instructions

Thanks for your pull request!

authentik translations are handled using Transifex. Please edit translations over there and they'll be included automatically.

@netlify
Copy link

netlify bot commented Jan 8, 2026

Deploy Preview for authentik-integrations ready!

Name Link
🔨 Latest commit 8a64762
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/69612ceb3e47ce0008037527
😎 Deploy Preview https://deploy-preview-19229--authentik-integrations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@GirlBossRush GirlBossRush changed the title web: 2026.12 UI feedback web: 2026.12 RC2 UI feedback Jan 8, 2026
@GirlBossRush GirlBossRush changed the title web: 2026.12 RC2 UI feedback web: 2025.12 RC2 UI feedback Jan 8, 2026
Copy link
Contributor

@kensternberg-authentik kensternberg-authentik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be broken up. :-)

@GirlBossRush
Copy link
Contributor Author

Resolved in each separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/version-2025.12 Add this label to PRs to backport changes to version-2025.12

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants