-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
web: Z-Index Fixes, Mobile Sidebar Behavior. #19460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| @@ -0,0 +1,189 @@ | |||
| :host { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bulk of this file is extracted verbatim from ak-page-navbar.ts, both for good housekeeping and to avoid Lit Analyzer's lack of container queries
edd1e5e to
dc1e256
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19460 +/- ##
==========================================
- Coverage 93.03% 92.53% -0.50%
==========================================
Files 949 949
Lines 52052 52052
==========================================
- Hits 48428 48168 -260
- Misses 3624 3884 +260
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-78f7c947f0f693d2e3f3316fb08e52a1c035b633
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-78f7c947f0f693d2e3f3316fb08e52a1c035b633Afterwards, run the upgrade commands from the latest release notes. |
kensternberg-authentik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's quite lovely work, and I appreciate pulling out the big CSS blobs into their own files.
web: Fix Z-Index issues, mobile sidebar behavior. Co-authored-by: Marcelo Elizeche Landó <[email protected]>
|
🍒 Cherry-pick to |
…ersion-2025.12) (#19492) web: Z-Index Fixes, Mobile Sidebar Behavior. (#19460) web: Fix Z-Index issues, mobile sidebar behavior. Co-authored-by: Teffen Ellis <[email protected]> Co-authored-by: Marcelo Elizeche Landó <[email protected]>
Details
This fixes several reported issues regarding z-index ordering in modals, headers, and the admin sidebar, along with a few variations on the issues for mobile and tablet viewports.This effort was initially introduced in #19152. This PR partially reverts to some of the Patternfly overrides we had in 2025.10, albeit with more targeted selection via CSS custom properties.
Fixes
Z-indexing
Z-indexes for drawers, sidebars, headings, and modals use fewer explicit z-indexes to allow for rendering order to take precedence in a few select areas.
Behaviors
Accessibility