Skip to content

Conversation

@GirlBossRush
Copy link
Contributor

@GirlBossRush GirlBossRush commented Jan 15, 2026

Details

This fixes several reported issues regarding z-index ordering in modals, headers, and the admin sidebar, along with a few variations on the issues for mobile and tablet viewports.This effort was initially introduced in #19152. This PR partially reverts to some of the Patternfly overrides we had in 2025.10, albeit with more targeted selection via CSS custom properties.

Fixes

Z-indexing

Z-indexes for drawers, sidebars, headings, and modals use fewer explicit z-indexes to allow for rendering order to take precedence in a few select areas.

Behaviors

  • The menu toggle button is moved into a slot to isolate the sidebar visibility state into a single element: the admin interface.
  • The admin sidebar now collapses itself after route changes on tablet and mobile viewports, rather than obscuring the page and requiring the user to manually close the menu.
  • The menu toggle button now only appears on viewport sizes when the sidebar sits on top of the content, matching our behavior on doc page sidebars.

Accessibility

  • A clickable backdrop area is added to the admin sidebar on mobile to match the modal backdrop behavior.

@GirlBossRush GirlBossRush added this to the Release 2025.12.1 milestone Jan 15, 2026
@GirlBossRush GirlBossRush added the area:frontend Features or issues related to the browser, TypeScript, Node.js, etc label Jan 15, 2026
@GirlBossRush GirlBossRush requested a review from a team as a code owner January 15, 2026 00:46
@netlify
Copy link

netlify bot commented Jan 15, 2026

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 78f7c94
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/69693079336e2f000801b399
😎 Deploy Preview https://deploy-preview-19460--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 15, 2026

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 78f7c94
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/69693079c8fac3000853cbc6
😎 Deploy Preview https://deploy-preview-19460--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@@ -0,0 +1,189 @@
:host {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bulk of this file is extracted verbatim from ak-page-navbar.ts, both for good housekeeping and to avoid Lit Analyzer's lack of container queries

@GirlBossRush GirlBossRush changed the title web: Fix Z-Index issues, mobile sidebar behavior. web: Z-Index Fixes, Mobile Sidebar Behavior. Jan 15, 2026
@GirlBossRush GirlBossRush added the backport/version-2025.12 Add this label to PRs to backport changes to version-2025.12 label Jan 15, 2026
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.53%. Comparing base (2c29698) to head (78f7c94).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19460      +/-   ##
==========================================
- Coverage   93.03%   92.53%   -0.50%     
==========================================
  Files         949      949              
  Lines       52052    52052              
==========================================
- Hits        48428    48168     -260     
- Misses       3624     3884     +260     
Flag Coverage Δ
conformance 38.27% <ø> (+<0.01%) ⬆️
e2e 44.10% <ø> (+0.91%) ⬆️
integration ?
unit 91.50% <ø> (+0.02%) ⬆️
unit-migrate 91.54% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-78f7c947f0f693d2e3f3316fb08e52a1c035b633
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-78f7c947f0f693d2e3f3316fb08e52a1c035b633

Afterwards, run the upgrade commands from the latest release notes.

Copy link
Contributor

@kensternberg-authentik kensternberg-authentik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's quite lovely work, and I appreciate pulling out the big CSS blobs into their own files.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in authentik Core Jan 15, 2026
@melizeche melizeche merged commit 0f11ad6 into main Jan 15, 2026
101 checks passed
@melizeche melizeche deleted the fix-safari-z-indexes branch January 15, 2026 19:03
@github-project-automation github-project-automation bot moved this from In Progress to Done in authentik Core Jan 15, 2026
authentik-automation bot pushed a commit that referenced this pull request Jan 15, 2026
web: Fix Z-Index issues, mobile sidebar behavior.

Co-authored-by: Marcelo Elizeche Landó <[email protected]>
@authentik-automation
Copy link
Contributor

🍒 Cherry-pick to version-2025.12 created: #19492

melizeche added a commit that referenced this pull request Jan 16, 2026
…ersion-2025.12) (#19492)

web: Z-Index Fixes, Mobile Sidebar Behavior. (#19460)

web: Fix Z-Index issues, mobile sidebar behavior.

Co-authored-by: Teffen Ellis <[email protected]>
Co-authored-by: Marcelo Elizeche Landó <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:frontend Features or issues related to the browser, TypeScript, Node.js, etc backport/version-2025.12 Add this label to PRs to backport changes to version-2025.12

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants