Fix Apron compare function usage
#1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sim642
added
type-safety
|
The new Apron is now published on opam (ocaml/opam-repository#26174) and all versions of Goblint are incompatible (ocaml/opam-repository#26199), so this fix is crucial for release. This is probably easiest done after #1522. |
|
Since the release on opam-repository, all our nightly unlocked CI builds fail spectacularly, so I'll just merge these fixes before #1522. A 1 minute sv-benchmarks run didn't reveal any new |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
antoinemine/apron#99 is mitigated by antoinemine/apron#108, which should be released as Apron v0.9.15 soon.
This PR aims to fix compatibility with this breaking change. It would be possible for us to implement a proper
GobApron.Environment.compare, but I don't know if we really need it.I'm more worried about our comparison of
Apron.Abstract1.t-s viaStdlib.compare, which won't work now. It doesn't seem to break our tests, but it might still be possible in some case we end up needing to call such comparison and crashing (which will explicitly break instead of being implicitly wrong sometimes).TODO