Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xerrors deprecations #405

Closed
wants to merge 1 commit into from
Closed

Conversation

nervo
Copy link
Contributor

@nervo nervo commented Oct 11, 2023

According to xerrors documentation (https://pkg.go.dev/golang.org/x/xerrors) Is and As methods have been deprecated in favor of standard errors package.

This PR:

  • Update xerrors to latest version
  • Rename internal package internal/errors to just internal to avoid name conflict with standard errors package
  • Switch every xerrors.Is / xerrors.As to its standard errors package equivalent

Fix #321

@codecov-commenter
Copy link

Codecov Report

Merging #405 (beb76d9) into master (0640a15) will not change coverage.
The diff coverage is 21.88%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #405   +/-   ##
=======================================
  Coverage   76.02%   76.02%           
=======================================
  Files          13       13           
  Lines        4692     4692           
=======================================
  Hits         3567     3567           
  Misses        866      866           
  Partials      259      259           

@goccy
Copy link
Owner

goccy commented Oct 28, 2024

I've already fixed this problem with latest release. Thank you for your reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/xerrors.As and x/xerrors.Is are deprecated but still used
3 participants