-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: preserve line breaks from original input #412
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #412 +/- ##
=======================================
Coverage 76.02% 76.02%
=======================================
Files 13 13
Lines 4692 4692
=======================================
Hits 3567 3567
Misses 866 866
Partials 259 259 |
@goccy I'd be interested to get your thoughts on this. If you specifically have reservations/thoughts on how the change could be behind a feature flag for backwards compatibility, let me know. |
lbc := "\n" | ||
prev := t.Prev | ||
var adjustment int | ||
// if the previous type is sequence entry user the previous type for that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// if the previous type is sequence entry user the previous type for that | |
// if the previous type is sequence entry use the previous type for that |
@goccy Kindly pinging you in cased you missed the previous notification. |
Motivation
Preserve the line breaks from input.
We use this project as dependency in a project that round trips YAML, this attempts to try and preserve the formatting. It will only ever add one line break between lines regardless of input.
Changes
checkLineBreak
method that uses the previous token to calculate if there should be a line breaktoken.SequenceEntryType
using the previous token of that.Checks