Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve defaults for zero initialised structs as well #442

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

yhabteab
Copy link
Contributor

@yhabteab yhabteab commented Mar 29, 2024

Before submitting your PR, please confirm the following.

---
first: "Test"
nested: # The decoder will always zero-initialise this nested struct and override the defaults
  # Just some comment here
#  val: "default"
  • Create test code that corresponds to the modification

fixes #441

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.78%. Comparing base (237df0e) to head (092b488).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
+ Coverage   78.77%   78.78%   +0.01%     
==========================================
  Files          13       13              
  Lines        4004     4007       +3     
==========================================
+ Hits         3154     3157       +3     
  Misses        591      591              
  Partials      259      259              

@yhabteab yhabteab force-pushed the preserve-map-struct-defaults branch from 1d13c5f to 092b488 Compare July 30, 2024 07:57
Copy link
Owner

@goccy goccy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution ! LGTM 👍

@goccy goccy merged commit 3a90d71 into goccy:master Jul 30, 2024
17 checks passed
@yhabteab yhabteab deleted the preserve-map-struct-defaults branch July 30, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decoder overrides defaults with null values
3 participants