fix out of range panic #467
Closed
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Korczynski <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #467 +/- ##
=======================================
Coverage 78.77% 78.77%
=======================================
Files 13 13
Lines 4004 4004
=======================================
Hits 3154 3154
Misses 591 591
Partials 259 259 |
AkihiroSuda
reviewed
Sep 4, 2024
| @@ -333,7 +333,7 @@ func Integer(tk *token.Token) *IntegerNode { | |||
| } | |||
| negativePrefix = "-" | |||
| } else { | |||
| if value[1] == 'o' { | |||
| if len(value) >= 2 && value[1] == 'o' { | |||
There was a problem hiding this comment.
Could you add a unit test that reproduce the panic issue?
goccy
requested changes
Oct 28, 2024
|
This problem has already been fixed with latest release. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, please confirm the following.
This fixes an out of range panic.