Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go version #122

Merged
merged 1 commit into from
May 16, 2024
Merged

Update Go version #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- name: setup go
uses: actions/setup-go@v4
with:
go-version: '1.21'
go-version-file: go.mod
- name: build kubejob
run: |
go build -o kubejob ./cmd/kubejob
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.21.0-bookworm
FROM golang:1.22.0-bookworm

ENV GOPATH /go
WORKDIR /go/src/github.com/goccy/kubejob
Expand All @@ -11,6 +11,6 @@ COPY . .

RUN go build -o /go/bin/kubejob-agent cmd/kubejob-agent/main.go

FROM golang:1.21.0-bookworm AS agent
FROM golang:1.22.0-bookworm AS agent

COPY --from=0 /go/bin/kubejob-agent /bin/kubejob-agent
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ job, err := kubejob.NewJobBuilder(cfg, "default").BuildWithJob(&batchv1.Job{
Containers: []corev1.Container{
{
Name: "test",
Image: "golang:1.21.0-bookworm",
Image: "golang:1.22.0-bookworm",
Command: []string{"echo", "hello"},
},
},
Expand Down Expand Up @@ -104,7 +104,7 @@ job, err := kubejob.NewJobBuilder(cfg, "default").BuildWithJob(&batchv1.Job{
Containers: []corev1.Container{
{
Name: "main",
Image: "golang:1.21.0-bookworm",
Image: "golang:1.22.0-bookworm",
Command: []string{"echo", "hello"},
},
{
Expand Down Expand Up @@ -232,7 +232,7 @@ Help Options:
### Example

```bash
$ kubejob --image golang:1.21.0-bookworm -- go version
$ kubejob --image golang:1.22.0-bookworm -- go version
go version
go version go1.21.0 linux/amd64
go version go1.22.0 linux/amd64
```
2 changes: 1 addition & 1 deletion job_cancel_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
)

const (
goTestImageName = "golang:1.21.0-bookworm"
goTestImageName = "golang:1.22.0-bookworm"
)

type jobClientWithBeforeCancel struct {
Expand Down
2 changes: 1 addition & 1 deletion job_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import (
)

const (
goImageName = "golang:1.21.0-bookworm"
goImageName = "golang:1.22.0-bookworm"
)

var (
Expand Down
2 changes: 1 addition & 1 deletion testdata/config/manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ spec:
serviceAccountName: kubejob
containers:
- name: kubejob
image: golang:1.21.0-bookworm
image: golang:1.22.0-bookworm
workingDir: /go/src/kubejob
command:
- tail
Expand Down
Loading